Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go work example go toolchain #7272

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

damiannolan
Copy link
Member

Description

Align with go.mod


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one side question is, does anyone currently use this? (Guess tho it doesnt hurt having it around either way!)

@crodriguezvega
Copy link
Contributor

Lgtm, one side question is, does anyone currently use this? (Guess tho it doesnt hurt having it around either way!)

I use it!

@damiannolan damiannolan added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit bfa40cb Sep 10, 2024
68 of 69 checks passed
@damiannolan damiannolan deleted the damian/update-go-work-example branch September 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants