refactor: Move Counterparty to packet server #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aditya <[email protected]>
Co-authored-by: Aditya <[email protected]>
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
srdtrk,
chatton,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
DimitrisJim
changed the title
AdityaSripal
approved these changes
Sep 11, 2024
| suite.Require().True(found, "GetCounterparty does not return counterparty") | ||
| suite.Require().Equal(counterparty, retrievedCounterparty, "Counterparty retrieved not equal") | ||
|
|
||
| retrievedCounterparty, found = suite.chainA.App.GetIBCKeeper().PacketServerKeeper.GetCounterparty(suite.chainA.GetContext(), "client-0") |
There was a problem hiding this comment.
maybe note this clientid doesn't exist or use ibctesting constant invalid client id (think it exists)
chatton
approved these changes
Sep 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As tiny as I could get this diff. Simply moves it over for now. Follow ups will add the a query server for packet server and change the counterparty struct to contain the additional identifiers.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.