feat: add protobuf files for channel/v2 genesis storage. #7502
Conversation
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
| // channel unique identifier. | ||
| string channel_id = 1; | ||
| // packet sequence. | ||
| uint64 sequence = 2; |
There was a problem hiding this comment.
basically a PacketSequence as defined underneath. Unsure if this wasn't used here in channel/v1 for some reason but keeping it separate for now (and possibly merge after bulk of genesis stuff is done)
There was a problem hiding this comment.
we need this also for some queries I think
| // channel unique identifier. | ||
| string channel_id = 1; | ||
| // packet sequence. | ||
| uint64 sequence = 2; |
There was a problem hiding this comment.
we need this also for some queries I think
| } | ||
|
|
||
| // PacketSequence defines the genesis type necessary to retrieve and store next send sequences. | ||
| message PacketSequence { |
There was a problem hiding this comment.
Feel like ChannelSequence makes more sense here, but fine we keeping the same as v1 if you want.
There was a problem hiding this comment.
will keep same for time being, can rename after getting other stuff in (should be a simple rename). Do think this does make sense to me too.
DimitrisJim
force-pushed
the
jim/7479-genesis-proto-channel-v2
branch
from
68cdd3b
to
84ef69b
Compare
|
Description
adds initial protobuf files for channel/v2 genesis.
part of: #7479
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.