fix: channel must exist before channel creator check #7538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjermundgaraba
requested review from
AdityaSripal,
damiannolan and
chatton
as code owners
gjermundgaraba
requested review from
DimitrisJim,
damiannolan,
chatton,
bznein and
AdityaSripal
and removed request for
damiannolan,
chatton and
AdityaSripal
DimitrisJim
approved these changes
Nov 6, 2024
| @@ -52,6 +52,7 @@ func (suite *KeeperTestSuite) TestRegisterCounterparty() { | |||
| { | |||
| "failure: channel must already exist", | |||
| func() { | |||
| suite.chainA.App.GetIBCKeeper().ChannelKeeperV2.DeleteCreator(suite.chainA.GetContext(), path.EndpointA.ChannelID) | |||
There was a problem hiding this comment.
is it necessary to delete the creator for this test case to pass? 🤔
There was a problem hiding this comment.
Not anymore, but it was needed to make the test fail in the first place. It passed before because the creator was still there (and it doesn't make a lot of sense for the creator to be present, but not the channel?).
Co-authored-by: DimitrisJim <[email protected]>
AdityaSripal
approved these changes
Nov 6, 2024
|
gjermundgaraba
deleted the
gjermund/register-counterparty-channel-exist-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed a bit of bad DX when I was sending in the wrong channel-id to register counterparty. Since it was checking the creator first, I got creator not found, when the real issue was that the channel id was not correct (channel not found). Moved the check up and adjusted the test to catch this.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.