Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove consumer panic when ccv channel is closed (backport #1127) #1136

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 12, 2023

This is an automatic backport of pull request #1127 done by Mergify.
Cherry-pick of 1412923 has failed:

On branch mergify/bp/release/v3.0.x/pr-1127
Your branch is up to date with 'origin/release/v3.0.x'.

You are currently cherry-picking commit 1412923.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md
	modified:   testutil/integration/debug_test.go
	modified:   x/ccv/consumer/module.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/integration/stop_consumer.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* rm panic

* rm tests

* Update CHANGELOG.md

* update comment

(cherry picked from commit 1412923)

# Conflicts:
#	tests/integration/stop_consumer.go
@mergify mergify bot requested a review from a team as a code owner July 12, 2023 14:59
@mergify mergify bot added the conflicts label Jul 12, 2023
@shaspitz shaspitz closed this Jul 12, 2023
@shaspitz shaspitz deleted the mergify/bp/release/v3.0.x/pr-1127 branch July 12, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant