Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: proper deletion of pending packets #1146

Merged
merged 7 commits into from
Jul 17, 2023
Merged

fix!: proper deletion of pending packets #1146

merged 7 commits into from
Jul 17, 2023

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Jul 13, 2023 •
edited
Loading

Description

Closes #1145

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@shaspitz shaspitz requested a review from a team as a code owner July 13, 2023 19:47
@shaspitz shaspitz changed the title fix: proper deletion of pending packets fix!: proper deletion of pending packets Jul 13, 2023
sainoe
sainoe approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MSalopek
MSalopek approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shaspitz shaspitz merged commit d77fbf4 into main Jul 17, 2023
10 checks passed
@shaspitz shaspitz deleted the shawn/fix-send-packets branch July 17, 2023 16:18
@shaspitz shaspitz mentioned this pull request Jul 17, 2023
Merged
20 tasks
insumity pushed a commit that referenced this pull request Jul 24, 2023
@shaspitz
fix!: proper deletion of pending packets (#1146)
af88d26 
* Update relay.go

* expectation func

* reg test

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainoe sainoe sainoe approved these changes

@MSalopek MSalopek MSalopek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect method of deleting pending consumer packets
3 participants
@shaspitz @sainoe @MSalopek