-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: avoid race condition in ICS misbehaviour handling #1148
Merged
mpoke
merged 31 commits into
sainoe/ics-misbehaviour-handling
from
sainoe/ics-misb-validation
Aug 11, 2023
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3114807
remove unwanted changes
sainoe fffeb07
fix hermes config with assigned key
sainoe 61d8012
revert unwanted changes
sainoe a11ee29
revert local setup
sainoe e79af1e
remove log file
sainoe 0a6cd87
typo
sainoe 9ad0721
update doc
sainoe e0de36d
update ICS misbehaviour test
sainoe 1b718be
update ICS misbehaviour test
sainoe 4357efa
revert mixed commits
sainoe 2be79d7
update ICS misbehaviour test
sainoe e734e53
update ICS misbehaviour test
sainoe 865e43b
Add test for MsgSubmitConsumerMisbehaviour parsing
sainoe 6874b00
fix linter
sainoe ad098b1
save progress
sainoe 71a087c
add CheckMisbehaviourAndUpdateState
sainoe 347cc7d
update integration tests
sainoe 4371701
typo
sainoe dc54dd1
remove e2e tests from another PRs
sainoe ea89a69
cleaning'
sainoe 92ba63d
Update x/ccv/provider/keeper/misbehaviour.go
sainoe e717632
Update x/ccv/provider/keeper/misbehaviour.go
sainoe 6330278
update integration tests
sainoe e7386f5
Merge branch 'sainoe/ics-misbehaviour-handling' into sainoe/ics-misb-…
sainoe d984377
save
sainoe 0dffa0a
save
sainoe 66b1069
Merge branch 'sainoe/ics-misbehaviour-handling' into sainoe/ics-misb-…
sainoe c5d5383
nits
sainoe ea3db32
remove todo
sainoe 12ed2a8
lint
sainoe 6cf1f4c
Update x/ccv/provider/keeper/misbehaviour.go
mpoke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ import ( | |
sdk "github.com/cosmos/cosmos-sdk/types" | ||
"github.com/cosmos/cosmos-sdk/types/msgservice" | ||
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types" | ||
"github.com/cosmos/ibc-go/v4/modules/core/exported" | ||
) | ||
|
||
// RegisterLegacyAminoCodec registers the necessary x/ibc transfer interfaces and concrete types | ||
|
@@ -40,6 +41,10 @@ func RegisterInterfaces(registry codectypes.InterfaceRegistry) { | |
(*sdk.Msg)(nil), | ||
&MsgSubmitConsumerMisbehaviour{}, | ||
) | ||
registry.RegisterInterface( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. It's not needed here. Removed in #1223. |
||
"ibc.core.client.v1.Misbehaviour", | ||
(*exported.Misbehaviour)(nil), | ||
) | ||
|
||
msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the check that the client is not expired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CometBFT
CheckMisbehaviourAndUpdateState
method callscheckMisbehaviourHeader
which performs the check.