Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding some info on ICS processes #1429

Merged
merged 12 commits into from
Nov 15, 2023
Merged

docs: adding some info on ICS processes #1429

merged 12 commits into from
Nov 15, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Nov 14, 2023

Description

Closes: NA


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)
  • Checked that the documentation website can be built and deployed successfully (run make build-docs)

@mpoke mpoke requested a review from a team as a code owner November 14, 2023 20:46
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

Left optional suggestions

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Show resolved Hide resolved
Copy link
Contributor

@insumity insumity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments but looks good to me.

RELEASES.md Show resolved Hide resolved
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

STATE-COMPATIBILITY.md Show resolved Hide resolved
STATE-COMPATIBILITY.md Outdated Show resolved Hide resolved
@mpoke mpoke merged commit d044f21 into main Nov 15, 2023
14 checks passed
@mpoke mpoke deleted the marius/ics-process branch November 15, 2023 16:06
MSalopek pushed a commit that referenced this pull request Dec 1, 2023
* moving docs/old/testing.md to TESTING.md

* adding release process

* adding info on ICS releases

* updating contributing guidelines

* apply review suggestions

* Update RELEASES.md

Co-authored-by: insumity <[email protected]>

* Update RELEASES.md

Co-authored-by: insumity <[email protected]>

* adding note about editor for unclog

* add some context on breaking changes

* adding context on state-compatibility

* Update STATE-COMPATIBILITY.md

Co-authored-by: insumity <[email protected]>

---------

Co-authored-by: insumity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants