Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli for consumer genesis transformation #1458

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Nov 28, 2023

Description

Closes: #1457

Fix cli command for consumer genesis transformation for retry_delay_period parameter which
did not exist in consumer parameters prior to version 3.
If retry_delay_period is not part of the export the default value will be used when generating the new format.

Note: without this fix, the consumer chain will report an invalid value and not come up.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@bermuell bermuell self-assigned this Nov 28, 2023
@bermuell bermuell marked this pull request as ready for review November 28, 2023 13:59
@bermuell bermuell requested a review from a team as a code owner November 28, 2023 13:59
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Nov 28, 2023
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

@bermuell bermuell merged commit 91d804a into main Nov 28, 2023
14 checks passed
@bermuell bermuell deleted the bernd/1457-ccv_consumer_genesis_transform branch November 28, 2023 14:16
mpoke added a commit that referenced this pull request Jan 9, 2024
@mpoke mpoke mentioned this pull request Jan 9, 2024
12 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccv consumer genesis transform should use default value for retry_delay_period
3 participants