Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: only validate active chains #2266

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

insumity
Copy link
Contributor

Description

Problem
See comment. There's no reason why a validator would have to validate a stopped chain.

Solution
Change hasToValidate so queries return correct whether a validator has to validate.
Also, modified jailing code so that from the moment a chain stops until it gets deleted, we cannot jail a validator for downtime.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@insumity insumity marked this pull request as ready for review September 13, 2024 11:40
@insumity insumity requested a review from a team as a code owner September 13, 2024 11:40
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Sep 13, 2024
// Expect packet not to bounce if the chain is launched
providerKeeper.SetSlashMeter(ctx, math.NewInt(-1))
providerKeeper.SetConsumerPhase(suite.providerCtx(), firstBundle.ConsumerId, providertypes.CONSUMER_PHASE_LAUNCHED)
ackResult, err = providerKeeper.OnRecvSlashPacket(ctx, packet, *slashPacketData)

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning test

This definition of err is never used.
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoke mpoke added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit f4ae106 Sep 13, 2024
16 checks passed
@mpoke mpoke deleted the insumity/only-validate-active-chains branch September 13, 2024 13:24
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
init commit

(cherry picked from commit f4ae106)
mpoke pushed a commit that referenced this pull request Sep 13, 2024
fix!: only validate active chains (#2266)

init commit

(cherry picked from commit f4ae106)

Co-authored-by: insumity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants