Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix list-consumer-chains CLI command #2313

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Sep 27, 2024

Fix nil pointer error in the list-consumer-chains query.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@sainoe sainoe requested a review from a team as a code owner September 27, 2024 16:35
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Sep 27, 2024
@mpoke mpoke added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 2, 2024
@mpoke mpoke added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit c8d13f5 Oct 3, 2024
14 of 15 checks passed
@mpoke mpoke deleted the sainoe/pagination-fix branch October 3, 2024 10:15
mergify bot pushed a commit that referenced this pull request Oct 3, 2024
fix list-consumer-chains query pagination

(cherry picked from commit c8d13f5)
mpoke pushed a commit that referenced this pull request Oct 3, 2024
fix: fix `list-consumer-chains` CLI command  (#2313)

fix list-consumer-chains query pagination

(cherry picked from commit c8d13f5)

Co-authored-by: Simon Noetzlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v6.1.x C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants