Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve UX by sending major version info #57

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: improve UX by sending major version info #57

merged 1 commit into from
Oct 30, 2023

Conversation

odeke-em
Copy link
Contributor

This change improves user experience (UX) by sending over the major version information. While here, also fixed up an unclear return.

Fixes #50
Fixes #51

@odeke-em
fix: improve UX by sending major version info
dc6d6fd 
This change improves user experience (UX) by sending
over the major version information. While here, also
fixed up an unclear return.

Fixes cosmos#50
Fixes cosmos#51
@odeke-em
Copy link
Contributor Author

Kindly cc-ing @julienrbrt

@julienrbrt
Copy link
Member

lgtm but Zondax is codeowner here.
cc @bizk

@bizk
Copy link

bizk commented Oct 27, 2023

Lgtm! nice improvement @odeke-em :) thx for the heads up @julienrbrt

@ftheirs ftheirs merged commit a4f5d04 into cosmos:master Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizk bizk bizk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@odeke-em @julienrbrt @bizk @ftheirs