Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing msg type when parse from event #1196

Merged
merged 15 commits into from
Oct 17, 2023
Merged

fix: add missing msg type when parse from event #1196

merged 15 commits into from
Oct 17, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented May 18, 2023 •
edited
Loading 

EventTypeChannelClosed

@mmsqe mmsqe marked this pull request as ready for review May 18, 2023 02:15
@agouin
Copy link
Member

agouin commented May 18, 2023

These new events will now be added to the cache, but nothing will be done with them after that.

EventTypeChannelClosed seems like a good one to handle to mark the channel closed in addition to the channel close confirm here

relayer/relayer/chains/cosmos/message_handlers.go

Line 90 in 45f478b

case chantypes.EventTypeChannelCloseConfirm:

It's not clear to me why the relayer would need to care about EventTypeUpgradeChain or EventTypeUpgradeClientProposal. Can you expand on that?

@mmsqe
Copy link
Contributor Author

mmsqe commented May 18, 2023

It's not clear to me why the relayer would need to care about EventTypeUpgradeChain or EventTypeUpgradeClientProposal. Can you expand on that?

I thought these two client events was missing when upgrade from ibc-go v6 to v7

jtieri
jtieri requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, always nice to remove some duplicated code.

My only nitpick would be can we rename utils.go to something like parsing.go, event_parser.go or something along those lines?

@jtieri jtieri merged commit cc75c04 into cosmos:main Oct 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@boojamya boojamya Awaiting requested review from boojamya

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsqe @agouin @jtieri