Skip to content

Commit

Permalink
Fix file encoding menu in status bar (fix #1731)
Browse files Browse the repository at this point in the history
  • Loading branch information
1024jp committed Sep 30, 2024
1 parent 92b7a9f commit 2e1ca4a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

### Fixes

- Fix an issue that the file encoding menu disappeared from the status bar.
- Fix an issue that document windows were not properly initialized when the windows minimized on launch.
- Fix an issue in the file browser that duplicate folders were displayed after renaming a folder.
- Fix an issue in the file browser that some actions for the root folder were incorrectly disabled.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ <h2>Improvements</h2>
<h2>Fixes</h2>

<ul>
<li>Fix an issue that the file encoding menu disappeared from the status bar.</li>
<li>Fix an issue that document windows were not properly initialized when the windows minimized on launch.</li>
<li>Fix an issue in the file browser that duplicate folders were displayed after renaming a folder.</li>
<li>Fix an issue in the file browser that some actions for the root folder were incorrectly disabled.</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ <h2>改良</h2>
<h2>修正</h2>

<ul>
<li>ステータスバーにファイルエンコーディングメニューが表示されなかった不具合を修正</li>
<li>アプリ起動時にウインドウがDockにしまわれていたときウインドウが正しく初期化されていなかった不具合を修正</li>
<li>フォルダ名を変更するとそのフォルダ項目が二重になったファイルブラウザの不具合を修正</li>
<li>ルートフォルダへのアクションが不要に無効になっていることがあったファイルブラウザの不具合を修正</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ private extension StatusBar.Model {

self.document?.counter.statusBarRequirements = []
self.countResult = document?.counter.result
self.fileEncoding = document?.fileEncoding

if let document, self.isActive {
document.counter.statusBarRequirements = UserDefaults.standard.statusBarEditorInfo
Expand All @@ -117,7 +118,6 @@ private extension StatusBar.Model {
]
} else {
self.documentObservers.removeAll()
self.fileEncoding = nil
self.lineEnding = nil
}
}
Expand Down

0 comments on commit 2e1ca4a

Please sign in to comment.