You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was universally returning true. Also remove the warnings check from the VS test since it makes no sense anymore and is really hard to in the isTrained test now that "untrained" is a warning. Add in a test for the C API to make sure it works correctly.
It was universally returning true. Also remove the warnings check from the VS test since it makes no sense anymore and is really hard to in the isTrained test now that "untrained" is a warning. Add in a test for the C API to make sure it works correctly.
I disagree about removing the warnings check; I think it's useful. And I have a separate PR where I fixed the tests by correctly setting the number of expected warnings. Could you take that out of this PR, and we can decide whether or not to do it?
Needing to know how many warnings are logged in order for a test to succeed is really quite obnoxious though. If I take it out of here I need a system of incrementing the expected warnings count by the number of sections since the check only resets at the end of the test....or something like that I can't remember but SECTION seems to mess with it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was universally returning true. Also remove the warnings check from the VS test since it makes no sense anymore and is really hard to in the isTrained test now that "untrained" is a warning. Add in a test for the C API to make sure it works correctly.