-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed limit param from vector_match() #2080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest vectorsearch extension, there were a couple of test failures caused by unexpected "Untrained index..." warnings.
snej
force-pushed
the
fix/vector_match_no_limit-CBL-5902
branch
from
June 24, 2024 19:43
cf41b43
to
64de52d
Compare
pasin
approved these changes
Jun 24, 2024
pasin
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"N1QL Vector Search" test needs update.
Error from PR validation for "N1QL Vector Search" test failure:
|
vector_match() no longer takes an optional 3rd parameter. The limit should now be passed as the overall LIMIT of the SELECT. Also switched to using MATCH instead of LIKE in the generated SQL, because I found MATCH is slightly more efficient.
snej
force-pushed
the
fix/vector_match_no_limit-CBL-5902
branch
from
June 24, 2024 21:47
64de52d
to
ab37982
Compare
Code Coverage Results:
|
pasin
approved these changes
Jun 24, 2024
callumbirks
pushed a commit
that referenced
this pull request
Jun 26, 2024
* Fixed vector-search test failures due to Untrained-index warning With the latest vectorsearch extension, there were a couple of test failures caused by unexpected "Untrained index..." warnings. * Removed limit param from vector_match() vector_match() no longer takes an optional 3rd parameter. The limit should now be passed as the overall LIMIT of the SELECT. Also switched to using MATCH instead of LIKE in the generated SQL, because I found MATCH is slightly more efficient. (cherry picked from commit dcaf693)
jianminzhao
added a commit
that referenced
this pull request
Jul 11, 2024
CBL-5813: Flaky test, "Multiple Collections Incremental Revisions" (#2088) dcaf693 Removed limit param from vector_match() (#2080) def4ffb Correct set vecOpt.lazy to lazyEmbedding. 7d953d8 Pick up VectorOptions.lazy from c4Options.lazy 312e654 Clear SQL statement bindings after use (#2072) 03ca4bd Use same vector-index options struct as vectorsearch repo (#2058) 280d305 Added explanatory note to c4index_beginUpdate doc-comment [CBL-5842] (#2070) CBL-5594: Increase Rev Tree Depth Limit to 100 (#2066) CBL-5785: Deadlock when setParentObjectRef is called (#2063) CBL-5639: Crash in setting Housekeeper::_doExpiration() (#2059) CBL-5685: Null dereference crash in gotHTTPResponse (#2060) CBL-5633: The mailbox's thread-pool may hang. (#2055) CBL-5798: Passive replicator incorrectly errors on collection ID in the BLIP message (#2051) bdcac52 Allow inspecting contents of vector index with c4db_getIndexRows() (#2050) 2c1f5f4 LazyIndex: reject wrong-dimensional vectors [CBL-5814] (#2053) CBL-5680 + CBL-5681: ReplacementRev enhancement (#2021) CBL-5688: Update replication protocol doc per ReplacementRev changes. (#2039)
jianminzhao
added a commit
that referenced
this pull request
Aug 26, 2024
CBL-5813: Flaky test, "Multiple Collections Incremental Revisions" (#2088) dcaf693 Removed limit param from vector_match() (#2080) def4ffb Correct set vecOpt.lazy to lazyEmbedding. 7d953d8 Pick up VectorOptions.lazy from c4Options.lazy 312e654 Clear SQL statement bindings after use (#2072) 03ca4bd Use same vector-index options struct as vectorsearch repo (#2058) 280d305 Added explanatory note to c4index_beginUpdate doc-comment [CBL-5842] (#2070) CBL-5594: Increase Rev Tree Depth Limit to 100 (#2066) CBL-5785: Deadlock when setParentObjectRef is called (#2063) CBL-5639: Crash in setting Housekeeper::_doExpiration() (#2059) CBL-5685: Null dereference crash in gotHTTPResponse (#2060) CBL-5633: The mailbox's thread-pool may hang. (#2055) CBL-5798: Passive replicator incorrectly errors on collection ID in the BLIP message (#2051) bdcac52 Allow inspecting contents of vector index with c4db_getIndexRows() (#2050) 2c1f5f4 LazyIndex: reject wrong-dimensional vectors [CBL-5814] (#2053) CBL-5680 + CBL-5681: ReplacementRev enhancement (#2021) CBL-5688: Update replication protocol doc per ReplacementRev changes. (#2039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vector_match() no longer takes an optional 3rd parameter.
The limit should now be passed as the overall LIMIT of the SELECT.
Also switched to using MATCH instead of LIKE in the generated SQL, because I found MATCH is slightly more efficient.
Also, with the latest vectorsearch extension, there were a couple of test failures caused by unexpected "Untrained index..." warnings. Fixed them.