Skip to content

Commit

Permalink
when running go tool pprof quote the path the SG binary so that space…
Browse files Browse the repository at this point in the history
…s in the path don't break the tool. (#2012)
  • Loading branch information
Andrew Reslan authored and tleyden committed Jul 27, 2016
1 parent de05976 commit 8c3ee28
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/sgcollect_info
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def make_collect_gotool_pprof_tasks(zip_dir, sg_binary_path, sg_url):
for format_type in format_types:
out_filename = "{0}.{1}".format(profile_type, format_type)
dest_path = os.path.join(os.environ["PPROF_TMPDIR"], out_filename)
cmd = "go tool pprof -{0} -seconds=5 {1} {2}/{3}".format(
cmd = 'go tool pprof -{0} -seconds=5 "{1}" {2}/{3}'.format(
format_type,
sg_binary_path,
sg_pprof_url,
Expand Down

0 comments on commit 8c3ee28

Please sign in to comment.