CBG-749 Backport CBG-471 to 2.7.2 - Pre-2.5 _attachment migration (#4…
bbrks
released this
12 May 23:02
…528) (#4535)
* Unit test repro
* Update test
Return hasPre25Attachments bool from revcache for upgrade case
fix _attachment in test
wip
Remove write part of attachment meta (rely on in-memory moving on each read)
Remove debug
Return error instead of panic
Reorder teardown to prevent panics using walrus
Improve comments, extra assertions on doc syncData
Remove unnecessary changes
* Reuse inject/MergeAttachment functions when injecting attachments into bodyBytes, add new tests to support mixed pre-2.5 and 2.5 meta
* Update to centralise attachment handling in getRevision
Co-authored-by: Adam Fraser <[email protected]>
Co-authored-by: Adam Fraser <[email protected]>