Merge pull request #236 from dejorrit/main

fix: make social container element a span
couetilc · Nov 26, 2023 · 51a796d · 51a796d
2 parents 1d46eb0 + fc66d4c
commit 51a796d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -140,4 +140,4 @@
     "react-dom": "^18.2.0"
   },
   "packageManager": "[email protected]"
-}
+}
diff --git a/src/component.jsx b/src/component.jsx
@@ -113,7 +113,7 @@ export const SocialIcon = React.forwardRef(function SocialIcon(props, ref) {
       'aria-label': ariaLabel,
       ref,
     },
-    <div className="social-container" style={social_container}>
+    <span className="social-container" style={social_container}>
       <svg
         role="img"
         aria-label={`${ariaLabel} social icon`}
@@ -141,7 +141,7 @@ export const SocialIcon = React.forwardRef(function SocialIcon(props, ref) {
           <path d={path} />
         </g>
       </svg>
-    </div>,
+    </span>,
     children,
   )
 })
diff --git a/test/unit/cases.js b/test/unit/cases.js
@@ -313,4 +313,10 @@ export const cases = ({ SocialIcon, getKeys }) =>
         )
       })
     }
+
+    // from https://github.com/couetilc/react-social-icons/pull/236
+    it('renders the svg within an inline element', ({ expect }) => {
+      render(<SocialIcon url={pinterest_url} />)
+      expect(link().querySelector('div')).toBeNull()
+    })
   })
-Original file line number
+Diff line change
@@ Expand Up / @@ -140,4 +140,4 @@ @@
         "react-dom": "^18.2.0"
       },
       "packageManager": "[email protected]"
-    }
+    }