Remove now-unnecessary db fixture

capone/tests/test_assert_transaction_in_ledgers_for_amounts_with_evidence.py

@@ -17,7 +17,7 @@
 from capone.tests.factories import UserFactory
 
 
-def test_transaction_fields(db):
+def test_transaction_fields():
     """
     Test filtering by `posted_timestamp`, `notes`, `type`, and `user`.
     """
@@ -51,7 +51,7 @@ def test_transaction_fields(db):
         )
 
 
-def test_no_matches(db):
+def test_no_matches():
     """
     No matching transaction raises DoesNotExist.
     """
@@ -71,7 +71,7 @@ def test_no_matches(db):
         )
 
 
-def test_multiple_matches(db):
+def test_multiple_matches():
     """
     Multiple matching transactions raises MultipleObjectsReturned.
     """
@@ -100,7 +100,7 @@ def test_multiple_matches(db):
         )
 
 
-def test_mismatch_on_ledger_entries(db):
+def test_mismatch_on_ledger_entries():
     """
     An otherwise matching Trans. will fail if its LedgerEntries mismatch.
     """
@@ -137,7 +137,7 @@ def test_mismatch_on_ledger_entries(db):
         )
 
 
-def test_mismatch_on_evidence(db):
+def test_mismatch_on_evidence():
     """
     An otherwise matching Trans. will fail if its evidence is different.
     """

capone/tests/test_create_transaction.py

@@ -24,7 +24,7 @@
 
 
 @pytest.fixture
-def create_objects(db):
+def create_objects():
     user = UserFactory()
     accounts_receivable = LedgerFactory(name='Accounts Receivable')
     cash_unrecon = LedgerFactory(name='Cash (unreconciled)')
@@ -219,7 +219,7 @@ def test_no_ledger_entries(create_objects):
         validate_transaction(user)
 
 
-def test_with_existing_ledger_entry(db):
+def test_with_existing_ledger_entry():
     amount = D(100)
     user = UserFactory()
 
@@ -293,26 +293,26 @@ def _create_transaction_and_compare_to_amount(
         assert entry2.amount == -amount
 
 
-def test_precision(db):
+def test_precision():
     _create_transaction_and_compare_to_amount(
         D('-499.9999'))
 
 
-def test_round_up(db):
+def test_round_up():
     _create_transaction_and_compare_to_amount(
         D('499.99995'), D('500'))
 
 
-def test_round_down(db):
+def test_round_down():
     _create_transaction_and_compare_to_amount(
         D('499.99994'), D('499.9999'))
 
 
-def test_round_up_negative(db):
+def test_round_up_negative():
     _create_transaction_and_compare_to_amount(
         D('-499.99994'), D('-499.9999'))
 
 
-def test_round_down_negative(db):
+def test_round_down_negative():
     _create_transaction_and_compare_to_amount(
         D('-499.99995'), D('-500'))

capone/tests/test_factories.py

@@ -24,7 +24,7 @@
 
 
 @pytest.fixture
-def credit_card_transaction(db):
+def credit_card_transaction():
     return CreditCardTransactionFactory()
 
 
@@ -61,7 +61,7 @@ def test_custom_ledger_entries(credit_card_transaction):
     )
 
 
-def test_custom_evidence(db):
+def test_custom_evidence():
     ccx = CreditCardTransactionFactory()
     TransactionFactory(evidence=[ccx])
 

capone/tests/test_filter_by_related_objects.py

@@ -20,7 +20,7 @@
 
 
 @pytest.fixture
-def create_transactions(db):
+def create_transactions():
     create_user = UserFactory()
     ledger = LedgerFactory()
 
@@ -90,7 +90,7 @@ def _create_transaction_with_evidence(evidence):
     (MatchType.EXACT, 'none'),
 ])
 def test_filter_with_no_evidence(
-    match_type, queryset_function_name, create_transactions, db,
+    match_type, queryset_function_name, create_transactions,
 ):
     """
     Method returns correct Transactions with no evidence given.
@@ -109,7 +109,7 @@ def test_filter_with_no_evidence(
     (MatchType.NONE, [False, False, False, True, False]),
     (MatchType.EXACT, [True, False, False, False, False]),
 ])
-def test_filters(match_type, results, create_transactions, db):
+def test_filters(match_type, results, create_transactions):
     """
     Method returns correct Transactions with various evidence given.
 
@@ -156,11 +156,7 @@ def test_filters(match_type, results, create_transactions, db):
     (MatchType.EXACT, 4),
 ])
 def test_query_counts(
-    match_type,
-    query_counts,
-    django_assert_num_queries,
-    create_transactions,
-    db,
+    match_type, query_counts, django_assert_num_queries, create_transactions,
 ):
     """
     `filter_by_related_objects` should use a constant number of queries.
@@ -187,7 +183,7 @@ def test_invalid_match_type():
         Transaction.objects.filter_by_related_objects(match_type='foo')
 
 
-def test_chaining_filter_to_existing_queryset(create_transactions, db):
+def test_chaining_filter_to_existing_queryset(create_transactions):
     """
     `filter_by_related_objects` can be used like any other queryset filter.
     """

capone/tests/test_ledger_balances.py

@@ -28,7 +28,7 @@
 
 
 @pytest.fixture
-def create_objects(db):
+def create_objects():
     order_1, order_2 = OrderFactory.create_batch(2)
     ar_ledger = LedgerFactory(name='A/R')
     cash_ledger = LedgerFactory(name='Cash')
@@ -270,7 +270,7 @@ def add_transaction(orders):
     )
 
 
-def test_ledger_balances_filtering(db, create_objects):
+def test_ledger_balances_filtering(create_objects):
     (
         order_1,
         order_2,

capone/tests/test_transaction_model.py

@@ -20,7 +20,7 @@
 from capone.tests.factories import UserFactory
 
 
-def test_unicode_methods(db):
+def test_unicode_methods():
     """
     Test all __str__ methods.
     """
@@ -58,7 +58,7 @@ def test_unicode_methods(db):
     )
 
 
-def test_transaction_summary(db):
+def test_transaction_summary():
     """
     Test that Transaction.summary returns correct information.
     """
@@ -81,15 +81,15 @@ def test_transaction_summary(db):
     }
 
 
-def test_setting_explicit_timestamp_field(db):
+def test_setting_explicit_timestamp_field():
     transaction = TransactionFactory()
     old_posted_timestamp = transaction.posted_timestamp
     transaction.posted_timestamp = timezone.now()
     transaction.save()
     assert old_posted_timestamp != transaction.posted_timestamp
 
 
-def test_editing_transactions(db):
+def test_editing_transactions():
     """
     Test that validation is still done when editing a Transaction.
 
@@ -110,7 +110,7 @@ def test_editing_transactions(db):
         transaction.save()
 
 
-def test_non_void(db):
+def test_non_void():
     """
     Test Transaction.objects.non_void filter.
     """

capone/tests/test_void.py

@@ -19,7 +19,7 @@
 
 
 @pytest.fixture
-def create_objects(db):
+def create_objects():
     creation_user = UserFactory()
     ar_ledger = LedgerFactory()
     rev_ledger = LedgerFactory()