Fixed the section parsing due to section name not being parsed properly

[anmolsahoo25]

🚨Please review the guidelines for contributing to this repository.

Proposed changes

Fixing the 0 courses available error.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• [x ] I have read the CONTRIBUTING doc
• [ x] I agree to contribute my changes under the project's LICENSE
• [x ] I have checked that the unit tests pass locally with my changes
• [x ] I have checked the style of the new code (lint/pep).
• [x ] I have added tests that prove my fix is effective or that my feature works
• [x ] I have added necessary documentation (if appropriate)

Further comments

Due to the new structure, the make title function was returning None. In turn, the filter for the properly parsed class was failing. I have tested my code for the EdX courses I am subscribed to, and it is working,

Reviewers

@rbrito

[Nocxy]

That doesn't work with me. I still have some kind of loop.

[anmolsahoo25]

Could you please post the error message?

[Nocxy]

There's no error message. I already posted what I have.

[anmolsahoo25]

Oh okay. Could you tell me the course link you are trying to download?

[Nocxy]

Ofx: click here. I don't know why but it's downloading every course a lot of times. This time, it downloaded me 15 times the first 5 videos.

[anmolsahoo25]

Strange. Seems to be working for me. Does it create separate folders for the units? Or everything in one place?

[Nocxy]

I guess I'd better provide you screenshots of the result. I downloaded it in a new repo to avoid problems. I should precise that I'm on mac but my Fedora is empty (still a lot to download in it to make it viable) and I don't use my Windows desktop atm... 2018-03-12 15:14 GMT+01:00 Anmol Sahoo <[email protected]>:

…

Strange. Seems to be working for me. Does it create separate folders for the units? Or everything in one place? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#491 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AijnQ8KKK97Vf_TfFm08Ijejpon3ZIfsks5tdoKogaJpZM4Slo9N> .

[anmolsahoo25]

Would be great if you could share the screenshot?

[Nocxy]

You mean sharing them on GH? 2018-03-16 8:25 GMT+01:00 Anmol Sahoo <[email protected]>:

…

Would be great if you could share the screenshot? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#491 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AijnQ2hxJEu8NUZNhFEXOqliTKP6Bmf1ks5te2jSgaJpZM4Slo9N> .

[Nocxy]

Btw, didn't you see the one I sent you via email? #487 I added a couple of screenshots 2018-03-16 22:48 GMT+01:00 Gauthier Delvaulx <[email protected]>:

…

You mean sharing them on GH? 2018-03-16 8:25 GMT+01:00 Anmol Sahoo ***@***.***>: > Would be great if you could share the screenshot? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#491 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AijnQ2hxJEu8NUZNhFEXOqliTKP6Bmf1ks5te2jSgaJpZM4Slo9N> > . >

[anmolsahoo25]

Hey. My bad. I saw the issue where you had posted the screenshots. Sorry about that.

[rbrito]

OK. As soon as you fix the merge conflict, I will pull your request and merge it.

Thanks.

[rbrito]

@anmolsahoo25, is this still the case? Apparently, if I understood things correctly, there is some merge conflict with the recent changes that I pushed to the master branch...

[anmolsahoo25]

@rbrito , Yes. I am working on it. Will try to fix it ASAP. Pretty new to contributing on Github, so I'm just getting used to it.