Upgrade to node20 and use @actions/glob for globbing and hashing files #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugo-vrijswijk
force-pushed
the
node-20-and-globs
branch
from
211b7ad
to
8263e12
Compare
Also updates tsconfig target to es2022 as this [fits with node 20](https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping)
hugo-vrijswijk
force-pushed
the
node-20-and-globs
branch
from
8263e12
to
770d1d7
Compare
dist is rebuilt on CI prior to testing things, and updated on the main branch by the update-dist workflow. No need to manually update it in PRs.
alexarchambault
approved these changes
Feb 1, 2024
|
Not sure what the formatting errors in the Windows jobs mean… I'm getting the same kind of error in coursier/setup-action#541. df6391e makes sure we just ignore them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zeit/nccwith@vercel/ncc(changed package name)@actions/globfunctions for globbing and hashing files instead of packages that are no longer maintainedsetup-nodeand the--openssl-legacy-provideris no longer needed