Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mantine): select asterisk color is too light #3932

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(mantine): select asterisk color is too light #3932

merged 1 commit into from
Oct 21, 2024

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented Oct 21, 2024 •
edited
Loading

Proposed Changes

The required asterisk of Select components had a shade too light when not in read only.

Before After
Normal image image
Read only image image

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@github-actions GitHub Actions
Copy link

✔️ Live demo of your latest successful build available here.

@gdostie gdostie marked this pull request as ready for review October 21, 2024 14:12
@gdostie gdostie requested a review from a team as a code owner October 21, 2024 14:12
@gdostie gdostie requested review from GermainBergeron and aboissinot-coveo and removed request for a team October 21, 2024 14:12
@gdostie gdostie merged commit becce83 into master Oct 21, 2024
6 checks passed
@gdostie gdostie deleted the ADUI-10303-select-asterisk-color branch October 21, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@aboissinot-coveo aboissinot-coveo Awaiting requested review from aboissinot-coveo aboissinot-coveo is a code owner automatically assigned from coveo/frontend-foundation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdostie @GermainBergeron