Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mantine): make EllipsisText style more adaptable #3947

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented Nov 11, 2024

Proposed Changes

When using the EllipsisText component inside other components like buttons or nav links, I realized that its style was sometimes creating unwanted overrides.

This PR makes the component more adaptable to its parent style:

  • Changing the Text node to be a span instead of a p
  • Adding inherit prop on the text node, so that it can take its parent text styles
  • Ensuring width and display can easily be overridden via the styles API

Potential Breaking Changes

None, the component should look exactly as it did before

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

Copy link

@gdostie gdostie marked this pull request as ready for review November 11, 2024 15:58
@gdostie gdostie requested a review from a team as a code owner November 11, 2024 15:58
@gdostie gdostie requested review from GermainBergeron, FelixBlaisThon and aboissinot-coveo and removed request for a team November 11, 2024 15:58
@gdostie gdostie merged commit ad5f31e into master Nov 11, 2024
6 checks passed
@gdostie gdostie deleted the ellipsis-text-adjustments branch November 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants