fix(mantine): make EllipsisText style more adaptable #3947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When using the EllipsisText component inside other components like buttons or nav links, I realized that its style was sometimes creating unwanted overrides.
This PR makes the component more adaptable to its parent style:
span
instead of ap
inherit
prop on the text node, so that it can take its parent text styleswidth
anddisplay
can easily be overridden via the styles APIPotential Breaking Changes
None, the component should look exactly as it did before
Acceptance Criteria