Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mlx): edit table.predicate to be able to change width of dropdown #3949

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

paulgerold
Copy link
Contributor

@paulgerold paulgerold commented Nov 11, 2024

Proposed Changes

Added the ability to modify the comboboxProps property to be able to change the width of the dropdown for example
This will allow me to modify the size of the dropdown for the model listing page table and be able to delete the custom style on the table

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@paulgerold paulgerold requested a review from a team as a code owner November 11, 2024 20:39
@paulgerold paulgerold requested review from GermainBergeron and gdostie and removed request for a team November 11, 2024 20:39
Copy link

Copy link
Member

@GermainBergeron GermainBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GermainBergeron GermainBergeron merged commit baf2888 into master Nov 14, 2024
6 checks passed
@GermainBergeron GermainBergeron deleted the MLX-1649-edit-the-table-predicate-on branch November 14, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants