Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompt): +disabledwithtooltip on confirm button #3952

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

FelixBlaisThon
Copy link
Contributor

@FelixBlaisThon FelixBlaisThon commented Nov 13, 2024

Proposed Changes

This feature will unblock this task
https://coveord.atlassian.net/browse/ADUI-10365

This PR adds the ButtonDisabledTooltip to the Prompt.Confirm button so that we can use the button component with the functionality of the tooltips

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@FelixBlaisThon FelixBlaisThon requested a review from a team as a code owner November 13, 2024 17:39
@FelixBlaisThon FelixBlaisThon requested review from GermainBergeron and gdostie and removed request for a team November 13, 2024 17:39
Copy link

@FelixBlaisThon FelixBlaisThon merged commit 7541d78 into master Nov 14, 2024
6 checks passed
@FelixBlaisThon FelixBlaisThon deleted the ADUI-10365-add-tooltip-to-prompt-confirm branch November 14, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants