draft #4363
Draft
draft #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salesforce LWS has a problem with static resources files using async/await on Firefox. This PR adds a script to use Babel to transform the headless.js files we use to transform async to promises. - Add babel to quantic - Use babel plugin @babel/plugin-transform-async-to-generator to transform built headless.js to transform async to promise. - Added this step prior to running the copy-static-resource in the nx build script.
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
louis-bompart
approved these changes
Aug 29, 2024
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
…ue with firefox (#4620) ## [SFINT-5784](https://coveord.atlassian.net/browse/SFINT-5784) continuation of @erocheleau 's work: #4363 As @erocheleau added in his PR: Salesforce LWS has a problem with static resources files using async/await on Firefox, before this PR the search interface indefinitely loads in Firefox when LWS is enabled. This PR adds a script to use Babel to transform the headless.js files we use to transform async to promises. Add babel to quantic Use babel plugin @babel/plugin-transform-async-to-generator to transform built headless.js to transform async to promise. Added this step prior to running the copy-static-resource in the nx build script. - Made sure this is still working correctly with Quantic and Headless v3. - Confirmed that the size of the Headless bundle after applying the babel async await plugin is not significantly bigger. - Confirmed that the search interface loads properly in Firefox. ### Before: https://github.com/user-attachments/assets/e6471fd9-d219-42ca-be93-05d2972e7937 ### After: https://github.com/user-attachments/assets/f5c880b0-c164-473d-88ad-3de62efd0bee ### Headless Size Before: <img width="500" alt="Screenshot 2024-11-05 at 3 29 43 PM" src="https://github.com/user-attachments/assets/371ecfa6-898c-4486-a97d-68dbc4b42f1f"> ### Headless Size After: <img width="500" alt="Screenshot 2024-11-05 at 3 29 59 PM" src="https://github.com/user-attachments/assets/a71c0ba9-163c-48b3-a2c7-7a231ad6122a"> [SFINT-5784]: https://coveord.atlassian.net/browse/SFINT-5784?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salesforce LWS has a problem with static resources files using async/await on Firefox.
This PR adds a script to use Babel to transform the headless.js files we use to transform async to promises.
If I correctly understands Babel's documentation.
presetin babel configuration, it won't do anything.@babel/plugin-transform-async-to-generatorincluded in the list ofplugins: []in thebabel.config.jsonasync/awaitnatively. (markedjs, dompurify, and Bueno don't use those)Comparison of bundle sizes
Before Babel transformation
After Babel transformation