Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quantic): added E2E and unit tests for insight notify trigger in quantic #4528

Merged
merged 15 commits into from
Oct 23, 2024
Merged

feat(quantic): added E2E and unit tests for insight notify trigger in quantic #4528

merged 15 commits into from
Oct 23, 2024

Conversation

SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Oct 10, 2024 •
edited
Loading

SFINT-5766

IN THIS PR:

  • Modified E2E tests to support insight use case for notify triggers in Cypress
  • Added unit tests for the quanticNotifications component

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 339.3 339.3 0
search 412 412 0
insight 400 400 0
recommendation 248.8 248.8 0
ssr 405.7 405.7 0
ssr-commerce 351.6 351.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@SimonMilord SimonMilord marked this pull request as ready for review October 11, 2024 20:29
@SimonMilord SimonMilord requested a review from a team as a code owner October 11, 2024 20:29
@developer-experience-bot
[Version Bump][skip ci]: ui-kit publish
ca534a2 
@coveo/[email protected]
@coveo/[email protected]
@coveo/[email protected]
@coveo/[email protected]

**/CHANGELOG.md
**/package.json
CHANGELOG.md
package.json
package-lock.json
mmitiche
mmitiche approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! nice job!
Just couple last remarks needed before merge!

packages/quantic/cypress/e2e/default-1/notifications/notifications.cypress.ts Outdated Show resolved Hide resolved
...antic/force-app/main/default/lwc/quanticNotifications/__tests__/quanticNotifications.test.js Show resolved Hide resolved
...antic/force-app/main/default/lwc/quanticNotifications/__tests__/quanticNotifications.test.js Outdated Show resolved Hide resolved
...antic/force-app/main/default/lwc/quanticNotifications/__tests__/quanticNotifications.test.js Show resolved Hide resolved
@louis-bompart louis-bompart requested a review from a team as a code owner October 18, 2024 21:06
fbeaudoincoveo
fbeaudoincoveo requested changes Oct 22, 2024
View reviewed changes
packages/atomic-angular/package.json Outdated Show resolved Hide resolved
packages/atomic-angular/projects/atomic-angular/package.json Outdated Show resolved Hide resolved
packages/atomic-react/CHANGELOG.md Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
packages/atomic-react/package.json Outdated Show resolved Hide resolved
packages/samples/atomic-react/package.json Outdated Show resolved Hide resolved
packages/samples/iife/package.json Outdated Show resolved Hide resolved
packages/samples/stencil/package.json Outdated Show resolved Hide resolved
packages/samples/vuejs/package.json Outdated Show resolved Hide resolved
packages/quantic/cypress/e2e/default-1/notifications/notifications.cypress.ts Show resolved Hide resolved
@SimonMilord SimonMilord added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit a114213 Oct 23, 2024
191 of 194 checks passed
@SimonMilord SimonMilord deleted the SFINT-5766 branch October 23, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitiche mmitiche mmitiche approved these changes

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@erocheleau erocheleau Awaiting requested review from erocheleau erocheleau is a code owner automatically assigned from coveo/salesforce-integration

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonMilord @fbeaudoincoveo @mmitiche