Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(quantic): first setup of playwright added in Quantic #4597
base: master
Are you sure you want to change the base?
test(quantic): first setup of playwright added in Quantic #4597
Changes from all commits
0b0f35b
5db6159
5cbb204
dd0e45b
438ee6c
389aef4
56518c5
4a9bef5
9ce1e39
638fdd7
633199a
ec9389b
8b977e3
f9cb518
95e305e
4fbdab8
18f60ce
5657e80
41d6065
b7163a5
f99a550
b8228b7
2ff3fe7
a8466e1
4cfbda2
8df0cd4
804495d
60472e8
ba69882
0cafffa
4b08487
04ad5c8
ea8b9d0
446457f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why those rules overrides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's because Jest defines
expect
as a global variable, and in the e2e tests we importingexpect
from playwright,so eslint creates an error saying that we can't re-declare a global variable.
this rule avoids this error.
An alternative solution would be to do:
by changing the alias of the imported expect playwright.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these coming from the
test.use
?This is what I was thinking we could do to simplify the useCases too:
Basically is there a way to not have two fixtures,
testInsight
&testSearch
and simply have atestPager
fixture that instead gets auseCase
as an option?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the Pager Object is fully independent of the use case, it doesn't care at all about which use case you are is, which is my sense ideal. I'm not understanding why we would want to make it take a use case as a parameter?