Extend behavior of fail-on-error option to setup failures
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binary and exit with error code 1 on failure except if fail-on-error input option is set to true.
…pecific installation step so we can keep a generic call to each coveralls command and not have to create OS-specific steps for those too.
…ferent MacOS versions. Add debugging to macos install step to help resolve the issue if I'm wrong.
…t and done actions. Add parallel-finished input option to dynamically set in the context of action = done so that we can test coevralls done instead of coveralls report.
… option is set to true.
…-based debugging flags. Add comments for parallel setup steps on each OS, more helpful now with the more verbose conditionals we added to check that each step succeeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel changes to the orb changes here: coverallsapp/orb#46
Description
Make sure the
fail-on-erroroption's behavior also applies to failures of setup tasks, like:Rather than just to failures of the coveralls commands:
coveralls report; orcoveralls doneTo Do
fail-on-errorbehavior applies to any failures downloading, verifying the binary, or finding the binary after download and extraction in the environmentdebug: trueoption is set, so users have insight into setup failures.test.ymlworkflow to test the action in a matrix of each OS handled (ubuntu-latest|windows-latest|macos-latest) vs. each possible action (report|done).debug: trueoption will show which step failed on the given platform.