updated to be compatible with puppet 4.x strict variables #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@covermymeds is this module now abandoned? |
|
We're still using it, but don't appear to maintaining it very well. |
|
We had work slated for this shortly after your initial pr and i had planned to pull it into that, but ended up not occurring. I'll get testing around this in our env and cut a new release late this week or early next. Sorry for the delay in action on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using puppet 4 with strict_variables = true, found an uniniitialised variable. Have set a default to undef for all non-Debian environments, and an additional check to ensure the variable is set when in use.