Ensure resource ordering & Debian fix #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcstephens
suggested changes
Sep 20, 2016
| ensure => installed, | ||
| require => $package_require, | ||
| ensure => installed, | ||
| before => $package_require, |
There was a problem hiding this comment.
This reverses the ordering. On a RedHat box, it would say install package before setting up the repo, which is obviously a bad thing to do.
There was a problem hiding this comment.
Yeah, you're right. Sorry, I've overlooked that.
| owner => $user, | ||
| group => $group, | ||
| mode => '0640', | ||
| require => Anchor['pgbouncer::begin'], |
There was a problem hiding this comment.
Why not just require the package, instead of tying this to an anchor?
There was a problem hiding this comment.
Yes, that would be definitely better. Fixed in 1e64fd0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes resource ordering during first installation. First we need to install
pgbouncerpackage, then we can ensure file ownership (user account might not exist before).Second commit changes defaults for Debian, where pgbouncer files are owned by
postgresuser.