This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
WIP: Improve status code handling. #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| export function convertModelStatusCode(code: number): number { | ||
| return -code |
There was a problem hiding this comment.
I assume this is done to distinguish between "the model returned a non-zero status code" and "the runner returned a non-zero status code"? We aren't running on Windows on Actions so maybe not crucial, but negative exit codes aren't always handled nicely.
Perhaps for now it's enough to just have a single non-zero status code for "the model returned a non-zero code", since we log the model exit code anyway.
aeisenberg
reviewed
May 14, 2020
| Ok = 0, | ||
| InvalidArguments = 1, | ||
| UnknownError = 2, | ||
| DockerError = 5, |
There was a problem hiding this comment.
Add an unsupported region code, too?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.