Merge pull request #141 from blinkseb/fix_sf

Fix invalid initialization of BinnedValues
cp3-llbb · Feb 1, 2016 · 3e42230 · 3e42230
2 parents 3ce6545 + 66c0467
commit 3e42230
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/interface/BinnedValues.h b/interface/BinnedValues.h
@@ -33,6 +33,8 @@ struct BinnedValues {
         use_formula = rhs.use_formula;
         error_type = rhs.error_type;
         formula_variable_index = rhs.formula_variable_index;
+        maximum = rhs.maximum;
+        minimum = rhs.minimum;
     }
 
     BinnedValues() = default;
@@ -77,8 +79,8 @@ struct BinnedValues {
     std::vector<float> relative_errors_to_absolute(const std::vector<float>& array) const {
         std::vector<float> result(3);
         result[Nominal] = array[Nominal];
-        result[Up] = array[Nominal] * (1 + array[Up]);
-        result[Down] = array[Nominal] * (1 - array[Down]);
+        result[Up] = array[Nominal] * array[Up];
+        result[Down] = array[Nominal] * array[Down];
 
         return result;
     };