Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eyalroz_printf: Add version 6.2.0 #725

Merged
merged 6 commits into from
Jul 21, 2024
Merged

Conversation

crvux
Copy link

@crvux crvux commented Nov 30, 2023

A package for a library that provides a custom printf implementation. See https://github.com/eyalroz/printf.

  • I've followed this guide
    step by step carefully. [Yes]

  • I've checked this Git style guide. [Yes]
  • I've checked this CMake style guide. [Yes]
  • My change will work with CMake 3.5 (minimum requirement for Hunter). [Yes]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes]

@crvux
Copy link
Author

crvux commented Nov 30, 2023

CI / eyalroz_printf mingw-cxx17 windows-2019 failed because mingw not found:
File mingw32-make.exe not found in directory C:\ProgramData\chocolatey\bin (MINGW_PATH environment variable)

@NeroBurner
Copy link

#709

Unfortunately a known bug. But would be happy to review and merge a fix for it 😁

All other jobs are green. Just need some time to review your changes.

The printf library looks interesting.

Will fully review soon ish

@NeroBurner NeroBurner self-assigned this Nov 30, 2023
@NeroBurner NeroBurner added the package:new New package label Nov 30, 2023
Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't stop myself from peeking. And then I HAD to do the review 😁

examples/eyalroz_printf/config.cmake Outdated Show resolved Hide resolved
examples/eyalroz_printf/CMakeLists.txt Show resolved Hide resolved
examples/eyalroz_printf/config.cmake Outdated Show resolved Hide resolved
cmake/projects/eyalroz_printf/hunter.cmake Outdated Show resolved Hide resolved
cmake/projects/eyalroz_printf/hunter.cmake Outdated Show resolved Hide resolved
cmake/projects/eyalroz_printf/hunter.cmake Show resolved Hide resolved
examples/eyalroz_printf/config.cmake Outdated Show resolved Hide resolved
cmake/projects/eyalroz_printf/hunter.cmake Outdated Show resolved Hide resolved
cmake/projects/eyalroz_printf/hunter.cmake Outdated Show resolved Hide resolved
@crvux
Copy link
Author

crvux commented Jul 21, 2024

@NeroBurner Eyal released 6.2.0
Let's continue?

Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking gold. Thanks for the update and New package 🎉

@NeroBurner NeroBurner merged commit 2f3cf77 into cpp-pm:master Jul 21, 2024
20 checks passed
@NeroBurner
Copy link

@eyalroz
Copy link

eyalroz commented Sep 7, 2024

@NeroBurner : Wait, so - did you release this with version 6.2.0 or 6.2.0-b1?

@NeroBurner NeroBurner changed the title eyalroz_printf: Add version 6.2.0-b1 eyalroz_printf: Add version 6.2.0 Sep 9, 2024
@NeroBurner
Copy link

It's 6.2.0. Updated the release notes and this issue description. Thanks for the nudge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:new New package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants