Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing OS level dependencies added for units, rgdal V8, jqr and protolite packages, missing R dependencies concaveman and devtools added, typo corrected: "flexbility" to "flexibility" in three files #72

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

serhatcevikel
Copy link

@serhatcevikel serhatcevikel commented Jun 30, 2019

Missing OS level dependencies added for units, rgdal, V8, jqr and protolite packages in before_install directive of .travis.yml
Missing R dependencies concaveman and devtools added
Also typo corrected: "flexbility" to "flexibility" in three files.

Build of "units" package in travis throws the error:

"Configuration failed because libudunits2.so was not found. Try installing:
    * deb: libudunits2-dev (Debian, Ubuntu, ...)
    * rpm: udunits2-devel (Fedora, EPEL, ...)
    * brew: udunits (OSX)
"
Due to following error on build:

"checking for gdal-config... no
no
configure: error: gdal-config not found or not executable.
"

gdal and prof4 dependencies are added to "before_install" directive
libv8-dev added to before_install directive
@serhatcevikel serhatcevikel changed the title Typo corrected: "flexbility" to "flexibility" in three files Missing OS level dependencies added for units and rgdal packages, typo corrected: "flexbility" to "flexibility" in three files Jun 30, 2019
@serhatcevikel serhatcevikel changed the title Missing OS level dependencies added for units and rgdal packages, typo corrected: "flexbility" to "flexibility" in three files Missing OS level dependencies added for units, rgdal and V8 packages, typo corrected: "flexbility" to "flexibility" in three files Jun 30, 2019
As per "Configuration failed because libjq was not found.", libjq-dev is added
libprotobuf-dev protobuf-compiler added to before_install directive
@serhatcevikel serhatcevikel changed the title Missing OS level dependencies added for units, rgdal and V8 packages, typo corrected: "flexbility" to "flexibility" in three files Missing OS level dependencies added for units, rgdal V8, jqr and protolite packages, typo corrected: "flexbility" to "flexibility" in three files Jun 30, 2019
To address

"mkdir -p docs/images && cp images/* docs/images
cp: cannot stat ‘images/*’: No such file or directory"

error
To address:

"
Quitting from lines 143-153 (plotly_book.Rmd) 
Error: Package `concaveman` required for `geom_mark_hull`.
"
@serhatcevikel serhatcevikel changed the title Missing OS level dependencies added for units, rgdal V8, jqr and protolite packages, typo corrected: "flexbility" to "flexibility" in three files Missing OS level dependencies added for units, rgdal V8, jqr and protolite packages, missing R dependency concaveman added, typo corrected: "flexbility" to "flexibility" in three files Jun 30, 2019
To address

"Error in loadNamespace(name) : there is no package called 'devtools'"
@serhatcevikel serhatcevikel changed the title Missing OS level dependencies added for units, rgdal V8, jqr and protolite packages, missing R dependency concaveman added, typo corrected: "flexbility" to "flexibility" in three files Missing OS level dependencies added for units, rgdal V8, jqr and protolite packages, missing R dependencies concaveman and devtools added, typo corrected: "flexbility" to "flexibility" in three files Jun 30, 2019
@cpsievert
Copy link
Owner

Thank you for this @serhatcevikel, were you able to eventually install the package?

Looks like I have an images/ directory locally, which gets copied over to the docs/ folder at build time. I'll look into making that images/ folder public so that others can build the book

@serhatcevikel
Copy link
Author

Thank you for this @serhatcevikel, were you able to eventually install the package?

Looks like I have an images/ directory locally, which gets copied over to the docs/ folder at build time. I'll look into making that images/ folder public so that others can build the book

You're welcome @cpsievert . In fact I was stuck in two points, as I also mentioned in my e-mail to you, first it was the missing images directory, but I tricked the CI by creating an empty one. The second one is more problematic: plotly_book is the repo for the book but also is a meta-package called plotly-book for the dependencies. However, at one time during the installation the repo itself tries to source the plotly-book package, which of course could only be installed with the repo. So I think in order to overcome this vicious circle, the meta-package can be spinned-off to another repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants