Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless scripts. #111

Closed

Conversation

dmuylwyk
Copy link

Support for the -watch option was deprecated in June, 2023, rendering the _gencontinuous scripts useless.

@dmuylwyk dmuylwyk added the bug Something isn't working label Aug 26, 2024
@dmuylwyk dmuylwyk self-assigned this Aug 26, 2024
Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scripts actually come from the publisher, so even if you remove them, they'll just be added back the next time someone runs _updatePublisher. We should just run _updatePublisher and commit the latest scripts that result from that run.

@dmuylwyk
Copy link
Author

@brynrhodes, I did not realize the scripts get updated in that manner. In that case, I think we can simply reject and close this PR. The changes need to happen in other projects. I filed the following related issues:

@dmuylwyk dmuylwyk closed this Aug 27, 2024
@dmuylwyk dmuylwyk deleted the remove-redundant-scripts-using-deprecated-option branch August 27, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants