-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect edit pages to the previous page on save #16140
Open
brianjhanson
wants to merge
7
commits into
5.7
Choose a base branch
from
feature/cms-655-redirect-edit-pages-to-the-previous-page-on-save
base: 5.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Redirect edit pages to the previous page on save #16140
brianjhanson
wants to merge
7
commits into
5.7
from
feature/cms-655-redirect-edit-pages-to-the-previous-page-on-save
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjhanson
commented
Nov 18, 2024
@@ -717,6 +717,10 @@ | |||
} | |||
this.reload(); | |||
} | |||
|
|||
const url = new URL(window.location.href); | |||
url.searchParams.set('q', this.searchTerm); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandonkelly I don't think using q
here will cause any issues, but if you think it's likely to run into another query param, we can use something else.
…direct-edit-pages-to-the-previous-page-on-save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revival of #12400 which got closed accidentally.
Updates redirect URLs for elements and fields to return back to the referrer (when available) instead of the Element::getPostEditUrl() URL.
As an added bonus, search queries for searches using the vue AdminTable component will now be persisted to the URL.
Fixes #11261, #11246