Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7433] Able to bypass character limit in Simple Text field through XB #4205

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

[7433] Able to bypass character limit in Simple Text field through XB #4205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
436977c
[7433] Able to bypass character limit in Simple Text field through XB
jvega190 Oct 23, 2024
75f4591
[7433] Update craftercms_paste pre/post process calls to match v7
jvega190 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions static-assets/js/tinymce-plugins/craftercms_paste/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,18 +1739,16 @@
};

var setup$1 = function (editor) {
var plugin = editor.plugins.paste;
var preProcess = getPreProcess(editor);
if (preProcess) {
editor.on('PastePreProcess', function (e) {
preProcess.call(plugin, plugin, e);
});
const processEvent = (f) => (e) => {
f(editor, e);
};
const preProcess = getPreProcess(editor);
if (isFunction(preProcess)) {
editor.on('PastePreProcess', processEvent(preProcess));
}
var postProcess = getPostProcess(editor);
if (postProcess) {
editor.on('PastePostProcess', function (e) {
postProcess.call(plugin, plugin, e);
});
const postProcess = getPostProcess(editor);
if (isFunction(postProcess)) {
editor.on('PastePostProcess', processEvent(postProcess));
}
};

Expand Down
37 changes: 19 additions & 18 deletions ui/guest/src/controls/rte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export function initTinyMCE(

record.element.classList.remove(emptyFieldClass);

const maxLength = validations?.maxLength ? parseInt(validations.maxLength.value) : null;
window.tinymce.init({
license_key: 'gpl',
target: rteEl,
Expand All @@ -125,8 +126,24 @@ export function initTinyMCE(
plugins: ['craftercms_paste editform', rteSetup?.tinymceOptions?.plugins].filter(Boolean).join(' '), // 'editform' plugin will always be loaded
paste_as_text: type !== 'html',
paste_data_images: type === 'html',
paste_preprocess(plugin, args) {
window.tinymce.activeEditor.plugins.craftercms_paste_extension?.paste_preprocess(plugin, args);
paste_preprocess(editor, args) {
const currentContent = editor.getContent({ format: 'text' });
const fullContent = currentContent + args.content;
const maxLengthExceeded = maxLength && fullContent.length > maxLength;
if (maxLengthExceeded) {
post(
snackGuestMessage({
id: 'maxLength',
level: 'required',
values: {
maxLength: args.content.length === maxLength ? fullContent.length : `${fullContent.length}/${maxLength}`
}
})
);
args.content = args.content.substring(0, maxLength - currentContent.length);
}

window.tinymce.activeEditor.plugins.craftercms_paste_extension?.paste_preprocess(editor, args);
},
paste_postprocess(plugin, args) {
window.tinymce.activeEditor.plugins.craftercms_paste_extension?.paste_postprocess(plugin, args);
Expand Down Expand Up @@ -329,21 +346,6 @@ export function initTinyMCE(
});

editor.on('paste', (e) => {
const maxLength = validations?.maxLength ? parseInt(validations.maxLength.value) : null;
const text = (
e.clipboardData ||
// @ts-ignore
window.clipboardData
).getData('text');
if (maxLength && text.length > maxLength) {
post(
snackGuestMessage({
id: 'maxLength',
level: 'required',
values: { maxLength: text.length === maxLength ? text.length : `${text.length}/${maxLength}` }
})
);
}
if (type === 'textarea') {
// Doing this immediately (without the timeout) causes the content to be duplicated.
// TinyMCE seems to be doing something internally that causes this.
Expand All @@ -356,7 +358,6 @@ export function initTinyMCE(
}
}, 10);
}
// TODO: It'd be great to be able to select the piece of the pasted content that falls out of the max-length.
});

editor.on('keyup', (e) => {
Expand Down