-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh and object #206
Open
AbdelrhmanBassiouny
wants to merge
12
commits into
cram2:dev
Choose a base branch
from
AbdelrhmanBassiouny:mesh_and_object
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mesh and object #206
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
75c16a0
[WorldObject] Added callbacks for when objects are added or removed.
AbdelrhmanBassiouny b2564c9
[MeshLoading] added the ability to add a transformation to apply to t…
AbdelrhmanBassiouny 4fa042a
[MeshAndObject] Added methods that can directly calculate the boundin…
AbdelrhmanBassiouny f4f8fbe
Merge remote-tracking branch 'original_pycram_repo/dev' into mesh_and…
AbdelrhmanBassiouny fbd2134
[MeshAndObject] Added new failures for wrong or no geometry for link.
AbdelrhmanBassiouny 1093253
[MeshAndObject] modified doc of method.
AbdelrhmanBassiouny 0db8e9d
[MeshAndObject] Added rotated bounding box.
AbdelrhmanBassiouny 41ad375
Merge remote-tracking branch 'original_pycram_repo/dev' into mesh_and…
AbdelrhmanBassiouny b6bb696
[MeshAndObject] correcting the requested changes in review.
AbdelrhmanBassiouny cf019f2
[MeshAndObject] corrected method names.
AbdelrhmanBassiouny dfbdc8c
Merge remote-tracking branch 'original_pycram_repo/dev' into mesh_and…
AbdelrhmanBassiouny d74f7d6
[MeshAndObject] Added convex hull.
AbdelrhmanBassiouny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dont use a polytope here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add the convex hull version which is available directly from trimesh, but this does not remove the need for a rotated shape, because the rotation here is meant to rotate the shape to the current pose of the link, this rotation will also be needed in a polytope or a convex hull as we only get the points relative to the object origin and are aligned with world frame not with object current frame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a method to get convex hull