Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for Bosch with temperature float value #2068

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Feat: Add support for Bosch with temperature float value #2068

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e04a708
Add support for setting temperature with float value
zhixuan2333 Feb 19, 2024
ea11467
fix linter errors
zhixuan2333 Feb 19, 2024
b3d30e6
Update temperature conversion in IRBosch144AC class
zhixuan2333 Feb 19, 2024
ef60cb4
Refactor temperature handling in IRBosch144AC class
zhixuan2333 Feb 19, 2024
3c89258
fix lint
zhixuan2333 Feb 19, 2024
032be85
fix lint
zhixuan2333 Feb 19, 2024
57f8467
Update temperature conversion method in ir_Bosch.cpp and ir_Bosch.h
zhixuan2333 Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ir_Bosch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ stdAc::state_t IRBosch144AC::toCommon(void) const {
result.power = getPower();
result.mode = toCommonMode(getMode());
result.celsius = true;
result.degrees = getTemp();
zhixuan2333 marked this conversation as resolved.
Show resolved Hide resolved
result.degrees = getTempFloat();
result.fanspeed = toCommonFanSpeed(getFan());
result.quiet = getQuiet();
// Not supported.
Expand Down Expand Up @@ -273,7 +273,7 @@ String IRBosch144AC::toString(void) const {
static_cast<int>(stdAc::fanspeed_t::kAuto),
static_cast<int>(stdAc::fanspeed_t::kAuto),
static_cast<int>(stdAc::fanspeed_t::kMedium));
result += addTempToString(getTemp());
zhixuan2333 marked this conversation as resolved.
Show resolved Hide resolved
result += addTempToString(getTempFloat());
result += addBoolToString(_.Quiet, kQuietStr);
return result;
}
Expand Down
Loading