Skip to content

Commit

Permalink
accidental duplicate target
Browse files Browse the repository at this point in the history
  • Loading branch information
georgettica authored Oct 14, 2024
1 parent e095caa commit 66b3007
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/push-docker-on-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ jobs:
tags: ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}:${{ steps.get_tag.outputs.tag }}
# platforms: linux/arm64/v8,darwin/amd64,linux/amd64,windows/amd64,linux/amd64 # was what I was aiming for
# but locally I only got to these 3 (specifically linux/arm64/v8 but yeah)
platforms: linux/arm64,linux/amd64,linux/amd64
platforms: linux/arm64,linux/amd64
3 changes: 1 addition & 2 deletions docs/build_and_push_docker_image_workflow_documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ permissions:
context: .
push: true
tags: ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}:${{ steps.get_tag.outputs.tag }}
platforms: linux/arm64,linux/amd64,linux/amd64
platforms: linux/arm64,linux/amd64
```

- **Description**: Builds and pushes the Docker image to GHCR for the specified platforms.
Expand All @@ -128,7 +128,6 @@ The workflow builds Docker images for the following platforms:

- **linux/arm64**
- **linux/amd64**
- **linux/amd64** (Note: The duplication of `linux/amd64` may be unintended.)

**Note**: Initially, the aim was to build for additional platforms such as `darwin/amd64` and `windows/amd64`, but due to local limitations, the workflow currently builds for the platforms listed above.

Expand Down

0 comments on commit 66b3007

Please sign in to comment.