Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Add link to Academy into lower menu #526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Navigation: Add link to Academy into lower menu #526

wants to merge 1 commit into from

Conversation

matkuliak
Copy link
Contributor

@matkuliak matkuliak commented Sep 19, 2024 •
edited
Loading

Summary of the changes / Why this is an improvement

Adding link to Academy should increase visibility, sessions. Crosslinking is also good in general

Preview

https://crate-docs-theme--526.org.readthedocs.build/en/526/

Checklist

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2024
@msbt
Copy link
Collaborator

msbt commented Sep 19, 2024 •
edited
Loading

@matkuliak while we're at it, shouldn't we open those links in a new window with target="_blank"?

cc @amotl

@matkuliak
Copy link
Contributor Author

matkuliak commented Sep 19, 2024 •
edited
Loading

Yes, totally agreed. Thanks for the suggestion!
Will add a patch if @amotl isn't vehemently against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

@msbt msbt Awaiting requested review from msbt

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matkuliak @msbt @amotl