Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.rst for pypi upload #533

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix README.rst for pypi upload #533

merged 1 commit into from
Sep 4, 2024

Conversation

tomach
Copy link
Contributor

@tomach tomach commented Sep 2, 2024

Summary of the changes / Why this is an improvement

Pypi upload seems to fail when images have a scale factor. in this case twine reports:

$ twine check dist/*
Checking dist/croud-1.12.0-py2.py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be rendered on PyPI.                                                                                                                          
         line 50: Warning: Cannot scale image!                                                                                                                                                                      
           Could not get size from "https://github.com/crate/croud/actions/workflows/docs.yml/badge.svg":                                                                                                           
           Requires Python Imaging Library.                                                                                                                                                                         
           Reading external files disabled.                                                                                                                                                                         
WARNING  `long_description_content_type` missing. defaulting to `text/x-rst`.                                                                                                                                       
Checking dist/croud-1.12.0.tar.gz: FAILED
ERROR    `long_description` has syntax errors in markup and would not be rendered on PyPI.                                                                                                                          
         line 50: Warning: Cannot scale image!                                                                                                                                                                      
           Could not get size from "https://github.com/crate/croud/actions/workflows/docs.yml/badge.svg":                                                                                                           
           Requires Python Imaging Library.                                                                                                                                                                         
           Reading external files disabled.                                                                                                                                                                         
WARNING  `long_description_content_type` missing. defaulting to `text/x-rst`.

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@tomach tomach merged commit 0b16a53 into master Sep 4, 2024
10 checks passed
@tomach tomach deleted the ta/fix-pypi-upload branch September 4, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants