CI: Add support for Python 3.12 and 3.13 #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
python312
branch
4 times, most recently
from
03da8c5
to
068ddac
Compare
amotl
commented
Nov 6, 2024
tests/util/fake_cloud.py
Outdated
Comment on lines
51
to
63
| here = pathlib.Path(__file__) | ||
| self.ssl_cert = here.parent / "server.crt" | ||
| ssl_key = here.parent / "server.key" | ||
| self.socket = ssl.wrap_socket( # type: ignore[attr-defined] | ||
|
|
||
| # Instances of SSLSocket must be created using the | ||
| # `SSLContext.wrap_socket()` method. | ||
| # https://docs.python.org/3.12/library/ssl.html#socket-creation | ||
| context = ssl.create_default_context() | ||
| context.check_hostname = False | ||
| context.load_cert_chain(certfile=str(self.ssl_cert), keyfile=str(ssl_key)) | ||
|
|
||
| self.socket = context.wrap_socket( # type: ignore[attr-defined] | ||
| self.socket, | ||
| keyfile=str(ssl_key), | ||
| certfile=str(self.ssl_cert), | ||
| server_side=True, | ||
| ) |
There was a problem hiding this comment.
The canonical rewrite of that spot failed.
More information:
Apparently, it doesn't work any longer without additional modifiations to the test suite, to make the FakeCrateDBCloudServer work well again. See CI outcome.
amotl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
In
tests.util.fake_cloud.FakeCrateDBCloudServer,ssl.wrap_socket()is no longer supported.Stacking
That other PR needs to be merged first.