CI: Use make lint instead of lint action #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbraad
approved these changes
Mar 15, 2024
gbraad
reviewed
Mar 15, 2024
| @@ -24,7 +24,7 @@ jobs: | |||
| - name: Build | |||
| run: make cross | |||
| - name: lint | |||
| uses: golangci/golangci-lint-action@v3 | |||
| run: make lint | |||
There was a problem hiding this comment.
#50 will take care of keeping up to date both the golangci action and the golangci-lint version we use in tools .
cfergeau
requested changes
Mar 15, 2024
Since we already have `lint` target in the makefile which uses golanglint and current workflow have outdated action for it. Better to have same way to run linter either local or on CI.
|
/close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.