-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E] macos tray test automation #2153
Conversation
Can one of the admins verify this patch? |
c9a5d6b
to
e450661
Compare
45cb798
to
3f0a99f
Compare
Related to #2190 current install scenario fails randomly |
ebdfed1
to
72b2f65
Compare
17eba5e
to
aa07c17
Compare
Can you rebase ? Otherwise, Thanks a lot for automating this! |
aa07c17
to
a4619ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for refactoring :). I left a few minor comments and I didn't check if the build tags are all well placed. But I assume they are since you ran it on all platforms. Otherwise LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianriobo, jsliacan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
ee347e3
to
9123c46
Compare
9123c46
to
1081d63
Compare
/retest |
Looks good. Let's use them for the next release. |
Solution/Idea
Add E2E automation tests for macos tray. The automation for mac will use native solution based on applescripts to interact with the tray.
This PR includes the implementation for the initial set of e2e scenarios for ux components on MacOS platform. To accommodate that implementation a refactor on the testing structure was required in order to expand and reuse the functionality among all different types of test (integration and e2e)
Downstream CI run results for this PR:
The required parameters to run the ux scenarios are still missing on the downstream CI, ux feature was run manually on a mac instance with the current CRC version (1.25.0):
resulting on:
*errors are directly realated with tray-macos issue #84