Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to record start durations for crc cluster #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsliacan
Copy link
Collaborator

@jsliacan jsliacan commented Oct 19, 2022

Assumption is that CRC binary is present on the PATH and bundle & pull-secret paths are known.

Usage (the new part):

monictl -d=data -n=10 -r=true -b=$(HOME)/crc_libvirt_4.11.7_amd64.crcbundle -p=$(HOME)/crc-pull-secret

will produce a file ./data/startTimes.json with a list of entries representing the start durations for each of the 10 starts of CRC, such as:

[
 "8m27.1454971s",
 "8m25.148657577s",
 "9m19.564509963s",
 "8m54.313454648s",
 "8m26.010998226s",
 "8m19.892106621s",
 "10m38.801894407s",
 "11m11.13464198s",
 "9m7.621104928s",
 "8m23.418967388s"
]

With -r option, -b and -p flags are also needed, while -s is ignored. The tool basically has 2 modes now (cannot be run simultaneously with one command). First mode is start/stop duration, second mode is the rest of the monitoring. The latter requires a running cluster, so it's incompatible with the purpose of the first mode. Right now, if -r option is provided, only start/stop will be run. If -r option is not provided, only monitoring will be run.

If run using the crc binary from https://github.com/jsliacan/crc/tree/timeouts, the start times will include waiting for cluster readiness up to 30mins.

@adrianriobo
Copy link
Contributor

Can you add the options within the container to include the starting measure on the monitoring pipeline here is the line where the monitools exec cmd is composed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants