Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Propagate exceptions as higher as possible #83

Merged
merged 6 commits into from
Mar 10, 2021

Conversation

guillaumerose
Copy link
Contributor

so that the error is shown to the user and hopefully he can understand it.

  • DaemonCommander now throws exceptions
  • Running/Stopped statuses are no longer gray
  • Failure statuses are better reported (not just Unknown)
  • Menu enabling is handled by a single function

@cfergeau
Copy link
Contributor

cfergeau commented Mar 4, 2021

so that the error is shown to the user and hopefully he can understand it.

I'm actually not sure showing raw errors to the user make sense most of the time ;) It's just internal technical details, which ideally we'd turn into some more understandable higher level message. Quite hard though

Copy link
Member

@anjannath anjannath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Status are correctly reflected now, and code became much cleaner then before 🎉 Thanks!!

@anjannath anjannath merged commit a887ac0 into crc-org:master Mar 10, 2021
@anjannath
Copy link
Member

so that the error is shown to the user and hopefully he can understand it.

I'm actually not sure showing raw errors to the user make sense most of the time ;) It's just internal technical details, which ideally we'd turn into some more understandable higher level message. Quite hard though

Created #87 to track this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants