Make e2e tests more robust #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a NVME test to TestPCIIDs. Signed-off-by: Christophe Fergeau <[email protected]>
The loops over the macOS13-only tests and macOS14-only tests are exactly the same, this commit refactors them so that we have a single loop. Signed-off-by: Christophe Fergeau <[email protected]>
This introduces a retrySSHDial and reworks the API used to connect to the VM over vsock/tcp. This will be useful in subsequent commits which will add a way to error out from the test if the vfkit process unexpectedly stopped. Signed-off-by: Christophe Fergeau <[email protected]>
Instead of a for{} loop with a time.Sleep, this commit switches to using
select{} for retry loops. This is in preparation for catching unexpected
exits of the vfkit process while running the test
Signed-off-by: Christophe Fergeau <[email protected]>
This commit an a go routine which will `Wait()` for the vfkit process.
When it exits, it will push the corresponding error (or nil) to a
channel.
The code waiting for the VM to startup can then check for errors in
their select{} retry loop, and fail acccordingly.
This will make debugging test failures easier, as currently if the vfkit
process dies early, the test appears to be taking a very long time
without any indication as to what's going on.
Signed-off-by: Christophe Fergeau <[email protected]>
This captures vfkit stdout/stderr to a file to help understand some test failures. This file is currently removed after the test ends, its path needs to be changed if one needs to look at it after. Signed-off-by: Christophe Fergeau <[email protected]>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial goal of this PR was to add a NVME test.
However, it initially failed and this was quite hard to debug.
This PR reworks the code in test/ to make unexpected failures easier to catch.